mdhiggins / sonarr-sma

Sonarr docker based on linuxserver/sonarr with SMA built in using python3
MIT License
37 stars 18 forks source link

Use linuxserver/ffmpeg as a base image #50

Closed lizardfish0 closed 11 months ago

lizardfish0 commented 11 months ago

As discussed in #49.

Tried to make as few changes as possible to the existing environment variables so that this doesn't break user's setups.

This change now leaves build and develop in a slightly weird place. linuxserver/sonarr:develop is built on Alpine instead of Jammy (no discussion in their repo about consolidating the two). I haven't tried layering the images but I imagine there will be issues there.

build now has a slight divergence in config options. SMA_HWACCEL is no longer needed, but some might be relying on it to install libraries required by their custom ffmpeg binaries.

My vote would be to deprecate SMA_HWACCEL from build and have people use the "hidden" SMA_EXTRA_PACKAGES instead. Then, they can specify which image they want to compile from: jrottenberg/ffmpeg or linuxserver/ffmpeg using ffmpeg_source/ffmpeg_tag, and install any extra packages they need using that var.

lizardfish0 commented 11 months ago

Actually, I think the cleanest option might be to combine master and build. Let me know what you think of #51.