search

mdiep / MMMarkdown

An Objective-C framework for converting Markdown to HTML.
MIT License
1.25k stars 168 forks source link

HTMLStringWithMarkdown:error: throws if string is nil. #10

Closed tewha closed 11 years ago

tewha commented 11 years ago

HTMLStringWithMarkdown now throws if string is nil.

Updated test for new behaviour.

I used @throw instead of NSParameterAssert so the throw occurs even if assertions are off.

Replaces #8.

mdiep commented 11 years ago

Merged with a few adjustments/enhancements. Thanks!

tewha commented 11 years ago

I approve of the temporary variable! I'd have done that in my own code, but was trying to get a sense of your coding style and missed. :)

mdiep commented 11 years ago

Understandably. :) I think my style has developed a bit since I wrote the bulk of this code, so it's possible that the rest of the code doesn't completely match this.

This is a good reminder that I should write up my style guidelines and link to it from the README.