mdiep / MMMarkdown

An Objective-C framework for converting Markdown to HTML.
MIT License
1.25k stars 168 forks source link

Added Cocoapods podspec #43

Closed iosdev-republicofapps closed 9 years ago

iosdev-republicofapps commented 9 years ago

Added from Specs-master/Specs/MMMarkdown/0.3/MMMarkdown.podspec.json.

This allows those of us using cocoapods to manage dependencies to pull in the latest master commit of MMMarkdown. In order to to do that, the pod spec needs to be in the root of the repo as per http://guides.cocoapods.org/using/the-podfile.html#from-a-podspec-in-the-root-of-a-library-repo

All I did was copy the existing pod spec from the Cocoapods master spec repo and put it in the root of the MMMarkdown repo. This allows me to use MMMarkdown in my project in one of two ways:

# Use the latest GM release from cocoapods (currently version 0.3)
pod 'MMMarkdown'

# or use the latest commit to master
pod 'MMMarkdown', :git => 'https://github.com/mdiep/MMMarkdown.git'

I have tested both after the change and they both work so this is a low-risk merge.

Thanks for MMMarkdown - I'm really enjoying using it! :-)

mdiep commented 9 years ago

Sorry, but I don't use Cocoapods and can't be responsible for maintaining the podspec. But I'm happy to create a new release if that's ever helpful.

iosdev-republicofapps commented 9 years ago

Hi mdiep,

What if I volunteer to maintain the pod spec for MMMarkdown? I'd be happy to help! :-)

Any way you could cut a 0.3.1 or 0.4 release with the current state of master and I'd be happy to update the pod spec in the cocoapods main spec repo?

I totally respect that you don't use Cocoapods. :-)

That being said, many other developers do, and many other popular libraries like AFNetworking, etc do use cocoapods. So if we want to create a project that uses both AFNetworking (manage as cocoapods dependency) and MMMarkdown (manage by direct insertion into project or as git submodule) then it's tricky and we get odd collisions or inconsistencies between the two.

If we don't add a basic pod spec to MMMarkdown, then those who want to use the latest main commit of MMMarkdown need to fork and keep up-to-date with your master.

Honestly, unless you radically change the structure of the project, the pod spec is unlikely to change much if ever. All that would ever change would be:

tag - might go from 0.3 to 0.4 platforms - might change if min deployment targets change from iOS 5.0 and OS X 10.6

I'm totally not trying to be a pain in the posterior, and I'm willing to maintain the pod spec, but if this doesn't seem worth it or is too much trouble then no worries, it was just a friendly suggestion. :-)

I'm happy to help with this cool project in any way.

Best wishes and thanks for making MMMardown available to us!

iosdev-republicofapps commented 9 years ago

Sorry, I'm not trying to be pushy about this. I was just trying to help. If you don't want to include Cocoapods specs, I'll just periodically sync from your master to my fork.

Thanks and best wishes.

mdiep commented 9 years ago

I'd rather not include a CocoaPods spec here. But I will happily release a new version. I'm currently traveling, but I'll try to do so in the next few days. :relaxed:

iosdev-republicofapps commented 9 years ago

That's cool. Thanks for the update and the new release is not urgent as I'm using master from my own fork for the next few weeks.

Enjoy your travels!

mdiep commented 9 years ago

I just created a 0.4 release.

iosdev-republicofapps commented 9 years ago

Thanks! I really appreciate the updated.

I'll update the cocoa pods pod spec in the master cocoa pods repo. :-)

Were there any major changes to the project builds or just new source files and some altered Xcode project settings? I looked over the commits and didn't see any major changes to how the project is built.

mdiep commented 9 years ago

I don't recall there being any major changes.

iosdev-republicofapps commented 9 years ago

Thanks.

I just pushed the 0.4 pod spec to cocoa pods.

Best wishes.