search

mdiep / MMMarkdown

An Objective-C framework for converting Markdown to HTML.
MIT License
1.25k stars 168 forks source link

Lack of support for image links #56

Closed albertbori closed 9 years ago

albertbori commented 9 years ago

The following markdown should produce an image link:

[![Werewolf Cop](http://ecx.images-amazon.com/images/I/51UENmW1sgL._SL175_.jpg)](http://www.amazon.com/exec/obidos/ASIN/1605986984/ref=nosim/founders-20)

Like so: Werewolf Cop

Instead, it produces the following: Werewolf Cop

mdiep commented 9 years ago

Thanks for the report! This is definitely a bug. I'll try to look into it sometime this week.

mdiep commented 9 years ago

I fixed this and created a new release (0.4.2) with the fix. :sparkles:

albertbori commented 9 years ago

Excellent! Thank you so much!

Mind bumping the cocoapod version?

mdiep commented 9 years ago

I don't use CocoaPods or have an interest in maintaining a spec. So someone else will need to do it. Sorry!

albertbori commented 9 years ago

Ok, I submitted a pull request to CocoaPods / Specs: https://github.com/CocoaPods/Specs/pull/13056

iosdev-republicofapps commented 9 years ago

I maintain the CocoaPods spec for this pod (as a volunteer) so I'll try to get out a release soon ...

iosdev-republicofapps commented 9 years ago

@albertbori I just updated and pushed a 0.4.2 pod spec. You might need to do pod repo update. Then:

shell> pod search MMMarkdown

-> MMMarkdown (0.4.2)
   An Objective-C static library for converting Markdown to HTML.
   pod 'MMMarkdown', '~> 0.4.2'
   - Homepage: https://github.com/mdiep/MMMarkdown
   - Source:   https://github.com/mdiep/MMMarkdown.git
   - Versions: 0.4.2, 0.4.1, 0.4, 0.3, 0.2.3, 0.2.1 [master repo]

So the latest 0.4.2 version is pushed to CocoaPods. Enjoy!

albertbori commented 9 years ago

Thanks for updating that. I've never worked with updating a repo that didn't have its own podspec.