search

mdinacci / MDRadialProgress

A custom UIView useful to represent progress in discrete steps.
Other
947 stars 159 forks source link

Purpose of MDRadialProgressTheme themeWithName:+ constructor ? #19

Closed nicolasgoutaland closed 10 years ago

nicolasgoutaland commented 10 years ago

Hi,

I think this method has no purpose actually. Was it supposed to enable support for shared theme accross application ?

Are you open to a pull request ?

I think we can handle a private dictionary, allowing use to return shared instance of themes accross application, allowing use for example to modify defaultTheme ?

Regards

mdinacci commented 10 years ago

Hello Nicolas,

the purpose of that method was simply to be able to offer multiple pre-configured themes. I abandoned the idea but I forgot to get rid of that method. I'm always open to pull requests but I'm picky and I would like to avoid adding code that is not strictly necessary.

nicolasgoutaland commented 10 years ago

In fact, when using it, I thought that default theme was shared accross all progress items by default, that is not the case. So I will open a pull request attending to add this behavior, and let you decide on what to add.