search

mdinacci / MDRadialProgress

A custom UIView useful to represent progress in discrete steps.
Other
947 stars 159 forks source link

Bugs fixed #5

Closed marcaudefroy closed 11 years ago

marcaudefroy commented 11 years ago

Hi Marcus,

I fixed bugs for :

Warning : The version is 0.3.0 but you renamed a public property. (http://semver.org)

mdinacci commented 11 years ago

Hi Marc,

why did you add:

if(self.progressCounter == 0){ endAngle = originAngle + 2*M_PI; }else{

from a first look it seems redundant to me because if progressCounter is 0 endAngle ends up being equal to originAngle which I think is fine.

As for the version, I'm not following semantic versioning, but thanks for the reminder. That said, after these changes are in I'll consider bumping up to 1.0.0.

marcaudefroy commented 11 years ago

Hi,

No, it isn't redundant because originAngle isn't equals to endAngle : there are an angle of 360 degrees. Before, there was an angle of 0 degrees. Do you understand? :)

mdinacci commented 11 years ago

Hi Marc,

thanks for your contribution.I merged it but I removed that code I was talking about in a previous comment since after testing it seems to have no effect. If you still think it is required, show me a case.

Marco

marcaudefroy commented 11 years ago

Hi Marcus :

Test with sliceDividerHidden = YES. Moreover, I'm sorry but i'm not fixed entirely the bug. (test with clockwise = YES ) I create a new pull request to correct this.

mdinacci commented 11 years ago

I tested with all possible combinations of sliceDividerHidden and clockwise:

yes_yes no_yes no_no yes_no

startingSlice = 5; progressTotal = 10; progressCounter = 4;

The picture is correct in any case.

marcaudefroy commented 11 years ago

And with progressCounter = 0 :D

mdinacci commented 11 years ago

crap, didn't try that...