search

mdittmer / object-graph-js

Object graphs from Javascript worlds
Apache License 2.0
1 stars 2 forks source link

Four visitor pattern changes #16

Closed mdittmer closed 6 years ago

mdittmer commented 6 years ago
  1. Bug fix: isPropertyBlacklisted() perform checks that do not require property lookup before doing lookup (which may throw);
  2. visitInstance(): Include properties from prototype chain that were undefined (in addition to those that threw, presumably due to getter invoked on non-instance);
  3. Consolidate "get function name" logic into method and use it for name matching in visitInstance();
  4. Relax conditions for triggering visitInstance().
mdittmer commented 6 years ago

@arobins PTAL. This is towards https://github.com/GoogleChrome/confluence/issues/173