search

mdittmer / object-graph-js

Object graphs from Javascript worlds
Apache License 2.0
1 stars 2 forks source link

Add QQ and UC as distinct browsers in NameRewriter #19

Closed foolip closed 6 years ago

foolip commented 6 years ago

Sample UA strings from Android:

QQ: Mozilla/5.0 (Linux; U; Android 8.1.0; en-us; Pixel 2 Build/OPM1.171019.011) AppleWebKit/537.36 (KHTML, like Gecko)Version/4.0 Chrome/57.0.2987.132 MQQBrowser/8.1 Mobile Safari/537.36

UC: Mozilla/5.0 (Linux; U; Android 8.1.0; en-US; Pixel 2 Build/OPM1.171019.011) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 UCBrowser/11.5.0.1015 U3/0.8.0 Mobile Safari/534.30

Sample UA strings from Windows:

QQ: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.26 Safari/537.36 Core/1.63.4533.400 QQBrowser/10.0.487.400

UC: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 UBrowser/7.0.185.1002 Safari/537.36

The regexes have been tested to match both variants of each.

foolip commented 6 years ago

With these changes, just by visiting the page with the "Collect data" button I should see UC or QQ as the browser name in the first line, right? I actually still see Chrome there, so I'm thinking the order probably matters?

foolip commented 6 years ago

Yay, it was the order, I got it to work. With that change I get filenames like data/og/window_QQ_8.1_Android_8.1.0.json