Update handling of UA/environment in ObjectGraph instances

mdittmer / object-graph-js

Object graphs from Javascript worlds

Apache License 2.0

1 stars 2 forks source link

Update handling of UA/environment in ObjectGraph instances #21

Closed mdittmer closed 6 years ago

mdittmer commented 6 years ago

UA:

Lock in on capture to ensure that it is an own property

Environment:

Copy from (default) UA during lazy data initialization
Can be overridden (since UA string does not always capture it precisely)
Store as JSON key (because it's not always derived from UA string anymore)

mdittmer commented 6 years ago

@foolip PTAL. Once this change is in place, a form for controlling ObjectGraph.environment can be implemented in https://github.com/mdittmer/web-apis

foolip commented 6 years ago

I read my notification in the wrong order: https://github.com/mdittmer/web-apis/pull/57