search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
93 stars 159 forks source link

'Email others' getting spammed #236

Open blue-hound opened 6 years ago

blue-hound commented 6 years ago

I have a course setup with a certificate for each topic. I have each certificate setup to email the student, email the teachers, and I have an email address in the 'email others' section. I just reset the course and all of the teachers received certificates twice. There were no certificates generated for students I assume because the didn't meet the restrict access criteria.

blue-hound commented 6 years ago

The certificates were generated for all of the teachers and email to us but if we view each individual activity there is only one certificate listed. For the non-editing teacher.

mdjnelson commented 6 years ago

What happens if you log in as a student and attempt to view the certificate? Are they able to? Certainly it shouldn't email you until the student is able to access the certificate as well - if it does, then there is a bug.

Perhaps creating a dummy student account and enrolling them in the course, checking if the emails are sent out when cron is run, if so, logging in as the dummy student and seeing what happens when you click on the certificate.

blue-hound commented 6 years ago

I do have a little bit more detail on this. The reason all the messages were getting sent out originally is because I was changing minor things in the certificate settings. For example, changing the restrict access parameters.

So certificates weren't being generated for students when I was making these changes. All of the students were suspended because we were still in testing. We have three types of teachers in this course. We have the tradition 'Teacher', the traditional 'Teacher (non-editing)' and I have a second role based on Teacher that has 'login as' enabled in the permissions but everything else is identical to 'Teacher' permission wise.

So, no certificates are being generated for the 'Teacher'. The 'Teacher (non-editing)' though is getting certificates generated every time a change is made to the certificate. They are getting emailed out and the certificate stays in the system and is verifiable. Certificates are also getting mailed out for the 'Teacher (login as)' but they aren't verifiable and they don't stay in the system.

Thanks!