search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
91 stars 158 forks source link

Background image no longer working #323

Open mdjnelson opened 4 years ago

mdjnelson commented 4 years ago

See https://moodle.org/mod/forum/discuss.php?d=396340.

mdjnelson commented 4 years ago

Also https://moodle.org/mod/forum/discuss.php?d=393185

EFoster1068 commented 4 years ago

Attached is the background that I am using. I also sent a picture of my template as I was editing and you can see where it moved out of the normal position. When I start editing the position will be correct. Then when I go to view the certificate and come back to edit a couple times it will move all of the elements including the background as seen below.

Website Example 2

Website Example

Background

emmarichardson commented 4 years ago

Is it that the background image moves or the other elements move? My background image seems to be just fine but the other elements do not display in the position they are set to when editing. They all move slightly.

EFoster1068 commented 4 years ago

It appears to me that the entire certificate is moving. When I go into the elements some of them at the top of the certificate have negative values in the position.

Eric

On May 26, 2020, at 8:28 AM, emmarichardson notifications@github.com wrote:



Is it that the background image moves or the other elements move? My background image seems to be just fine but the other elements do not display in the position they are set to when editing. They all move slightly.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-634024736, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZANPJDK7TBLHYAM5MLRTO7W7ANCNFSM4KSBWNDA.

EFoster1068 commented 4 years ago

Any success with solving this issue?

mdjnelson commented 4 years ago

Looking at this now.

mdjnelson commented 3 years ago

I can not replicate this, even with the image provided. It looks and works fine for me. I think this is a theme issue. Has anyone tried changing their theme to 'Classic' or 'Boost' temporarily and seeing if that fixes the problem?

EFoster1068 commented 3 years ago

I tried it on Adaptable, Boost and Classic and had the same issue. It seems like it is not placing the background in the square that appears when you set the size. Therefore everything is shifted up about 14-20 units. As you can see below the buttons "save and close" "save and continue" are not visible. in pic #2 Pics below are in the Classic Theme.

Certificate error 1 Certificate Error 2

mdjnelson commented 3 years ago

What width and height have you set your certificate to?

mdjnelson commented 3 years ago

II have been playing around with this for some time and can not replicate it. I added a grade and code element and moved them around and kept re-visiting the reposition page in both Boost and Classic and there were no issues.

emmarichardson commented 3 years ago

It is not that the items don’t move around - it is that they do not then preview in the place that you place them...

Emma

On Oct 12, 2020, 6:50 AM -0600, Mark Nelson notifications@github.com, wrote:

II have been playing around with this for some time and can not replicate it. I added a grade and code element and moved them around and kept re-visiting the reposition page in both Boost and Classic and there were no issues. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

mdjnelson commented 3 years ago

Can you tell me what width and height you have set for that page of the certificate?

emmarichardson commented 3 years ago

279 and 216

Emma

Emma Richardson Distance Learning Coordinator Direct: 719-650-3037 On Oct 14, 2020, 10:44 AM -0600, Mark Nelson notifications@github.com, wrote:

Can you tell me what width and height you have set for that page of the certificate? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

EFoster1068 commented 3 years ago

Width 280 Height 215

Eric Foster Builders Academy Houston, TX 281-558-4100

From: Mark Nelson notifications@github.com Sent: Wednesday, October 14, 2020 11:44 AM To: mdjnelson/moodle-mod_customcert moodle-mod_customcert@noreply.github.com Cc: Eric Foster Eric.Foster@buildersacademy.com; Comment comment@noreply.github.com Subject: Re: [mdjnelson/moodle-mod_customcert] Background image no longer working (#323)

Can you tell me what width and height you have set for that page of the certificate?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-708524359, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZA7MQQGAKE6ZTQT54DSKXINPANCNFSM4KSBWNDA.

EFoster1068 commented 3 years ago

Now that I have started working with the certificates more, it appears the issue arises while trying to set up the templates for the certificates to be used in multiple classes.

Eric Foster Builders Academy Houston, TX 281-558-4100

From: Mark Nelson notifications@github.com Sent: Wednesday, October 14, 2020 11:44 AM To: mdjnelson/moodle-mod_customcert moodle-mod_customcert@noreply.github.com Cc: Eric Foster Eric.Foster@buildersacademy.com; Comment comment@noreply.github.com Subject: Re: [mdjnelson/moodle-mod_customcert] Background image no longer working (#323)

Can you tell me what width and height you have set for that page of the certificate?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-708524359, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZA7MQQGAKE6ZTQT54DSKXINPANCNFSM4KSBWNDA.

jardao commented 3 years ago

I have the same problem also using an image (not a background image)

mdjnelson commented 3 years ago

What browser are you all using?

EFoster1068 commented 3 years ago

Chrome

Eric

On Nov 25, 2020, at 7:46 AM, Mark Nelson notifications@github.com wrote:



What browser are you all using?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-733715774, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZGPD3ODTXNDGBOQ6YLSRUDEDANCNFSM4KSBWNDA.

mdjnelson commented 3 years ago

Hm, same. I also set my width to 280 and height to 215, added a BG image, a normal image and when I press 'Save and continue' on the reposition page the images remain where they are and the buttons are not hidden by them.

mdjnelson commented 3 years ago
Testing issue 323
mdjnelson commented 3 years ago

See above. This is what I have. Are you running the latest 3.8 on github, or did you download from the plugins DB?

EFoster1068 commented 3 years ago

Version 3.8 from GitHub. Mine will start out in the correct position but then after I start adding more information ( sometimes 8-10 items) to the template it will then move everything up.

Eric

On Nov 25, 2020, at 7:57 AM, Mark Nelson notifications@github.com wrote:



See above. This is what I have. Are you running the latest 3.8 on github, or did you download from the plugins DB?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-733721764, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZHDFTSXAX7M6UJRDFLSRUEMNANCNFSM4KSBWNDA.

EFoster1068 commented 3 years ago

I have had someone work on this issue and it seems they found a solution. I would like to send the files to you so you can find what they came up with. I just need to know how to get them to you.

mdjnelson commented 3 years ago

Could they sign up to Github and put the solution in this comment section?

EFoster1068 commented 3 years ago

customcert-2021-01-15.zip

mdjnelson commented 3 years ago

Thanks. It would be preferable to see just the changes that were done (in a patch) but I can do a diff and see what the differences are.

joshwillcock commented 3 years ago

Thanks. It would be preferable to see just the changes that were done (in a patch) but I can do a diff and see what the differences are.

Hey Mark.

I've not had any involvement but have been watching this issue; I tried comparing the uploaded ZIP to help out but didn't have much luck.

It appears the developer added three lines to the savepositions function in rearrange-debug.js and rearrange.js window.scrollTo(0, 0); document.querySelector("body").style.height = '100%'; document.querySelector("body").style.overflow = 'hidden';

Commented out the whole of rearrange-min.js and replaced it's usage by writing the JS manually in rearrange.php This appears to be a full re-write rather than one or two small changes. I think if you can read what they wrote in rearrange.php line 135+ you might recognise something immediately different.

I was hoping originally to save you from the workload, but there is so much JS named slightly differently I didn't want to muddy the situation further.

Thanks for your hard work with this fantastic plugin!

mdjnelson commented 3 years ago

Thanks for doing research on this Josh. Much appreciated.

mdjnelson commented 3 years ago

@EFoster1068 are you able to provide a diff with the changes, or create a merge request?

EFoster1068 commented 3 years ago

I have never tried to do that.

Eric

On Mar 25, 2021, at 8:15 AM, Mark Nelson @.***> wrote:



@EFoster1068https://github.com/EFoster1068 are you able to provide a diff with the changes, or create a merge request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-806720735, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZBSMVB23E7SZEXYRTTTFMZNTANCNFSM4KSBWNDA.

estherkrisanti commented 2 years ago

I experience the same issue. Could you please help to share what should be changed? Thanks!

kpi6288 commented 2 years ago

I have the same issue using Trema design. Worked when I changed back to the Classic design, though.

Klaus

teruselearning commented 2 years ago

Occurring on a Vanilla Moodle 4.0 with boost and classic themes when managing templates for me.

shikizisykes26 commented 1 year ago

Hello, is the problem solved? what I experienced was for some certificates, the background image went up to the top to close the save and close button. I've tried changing the theme (boost and classic) but it's still the same, Please advise. i use moodle version : 3.11 plugin version : 3.11.1 (2021051701) theme : Edumy

EFoster1068 commented 1 year ago

To solve the problem. I discovered that if you create a template and do the editing on the template it will work.

Load the template to the course after all edits are completed.

Eric

On Nov 13, 2022, at 10:32 PM, shikizisykes26 @.***> wrote:



Hello, is the problem solved? what I experienced was for some certificates, the background image went up to the top to close the save and close button. I've tried changing the theme (boost and classic) but it's still the same, Please advise. i use moodle version : 3.11 plugin version : 3.11.1 (2021051701) theme : Edumy

— Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-1313085076, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZD3T3IGLTWVDAXDLULWIG6HRANCNFSM4KSBWNDA. You are receiving this because you were mentioned.Message ID: @.***>

EFoster1068 commented 1 year ago

Create a template and make all edits and then load the template to your course certificate.

Editing inside the certificate while in the course causes all of the issues of moving background.

Eric

On Nov 13, 2022, at 10:32 PM, shikizisykes26 @.***> wrote:



Hello, is the problem solved? what I experienced was for some certificates, the background image went up to the top to close the save and close button. I've tried changing the theme (boost and classic) but it's still the same, Please advise. i use moodle version : 3.11 plugin version : 3.11.1 (2021051701) theme : Edumy

— Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-1313085076, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZD3T3IGLTWVDAXDLULWIG6HRANCNFSM4KSBWNDA. You are receiving this because you were mentioned.Message ID: @.***>

mdjnelson commented 5 months ago

Looking at this again. It's been a while, sorry.

mdjnelson commented 5 months ago

I've tried switching themes, page height and width, adding numerous items but the reposition page is fine and the background image does not go outside of the designated area. I am only supporting 4.1 onwards so perhaps something has changed in core. Can someone confirm it still occurs for them in 4.1 or greater? If it does I really need replication steps. If a person can create a certificate from scratch that behaves wrongly remember each step and put it here. Thanks!