search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
91 stars 158 forks source link

Custom Cert email from address does not use the emailfromvia setting #471

Closed peverist closed 5 months ago

peverist commented 2 years ago

Moodle 3.10.6, custom certificate 3.10.1

The system I administer has the emailfromvia setting in Outgoing Mail Configuration set to 'always' which appends the site shortname to the from display name in system generated emails e.g. Do not reply to this email (via sitename)" ( Core noreplyname string plus site shortname) This helps our employees recognise the email as coming from our LMS and reduces staff reporting the emails as spam or phishing emails.

Emails generated by the Custom Certificate plugin do not include the (via sitename) additional information.

I have set the sitename as a subject prefix as well but it would also be good if the custom certificate from display name matches the from display name in other system generated emails.

Regards Phil

SliuzasLukas commented 5 months ago

Is there any update about this issue?

mdjnelson commented 5 months ago

Sorry, didnt get an email notifying me about this until @SliuzasLukas posted. I am now watching this project on GitHub so I get all emails, not just ones where I was mentioned.

This seems like an easy fix. Ill add it to my to-do list and it will be in the next release.

mdjnelson commented 5 months ago

Pushed fixes to 4.1 and 4.2.

SliuzasLukas commented 4 months ago

Hi,

Was the plugin updated?

mdjnelson commented 4 months ago

The change was done and the code is on GitHub but I have not updated the plugins in the Moodle plugins DB. Ill do that today.

mdjnelson commented 4 months ago

Updated in 4.1 and 4.2 on the plugins DB.

peverist commented 4 months ago

Thanks Mark - much appreciated.

Regards

Phil Everist Business Consultant (Digital Learning - THEO / HLO) Health ICT | Department of Health Level 2, 22 Elizabeth St Hobart Phone: 6166 6884 Email: @.*** Web: www.health.tas.gov.auhttp://www.health.tas.gov.au/

Please note the new THEO/HLO support email address For generic THEO/HLO/eLearning requests, email: @.**@.>

@.***

From: Mark Nelson @.> Sent: Tuesday, April 23, 2024 9:42 PM To: mdjnelson/moodle-mod_customcert @.> Cc: Everist, Phil @.>; Author @.> Subject: Re: [mdjnelson/moodle-mod_customcert] Custom Cert email from address does not use the emailfromvia setting (Issue #471)

External Sender - Exercise Caution

Updated in 4.1 and 4.2 on the plugins DB.

- Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/471#issuecomment-2072074857, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR6OIRJF4V6ZE7QXWOU3IYTY6ZCIVAVCNFSM5IC5BU32U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBXGIYDONBYGU3Q. You are receiving this because you authored the thread.Message ID: @.**@.>>

CONFIDENTIALITY NOTICE AND DISCLAIMER The information in this transmission may be confidential and/or protected by legal professional privilege, and is intended only for the person or persons to whom it is addressed. If you are not such a person, you are warned that any disclosure, copying or dissemination of the information is unauthorised. If you have received the transmission in error, please immediately contact this office by telephone, fax or email, to inform us of the error and to enable arrangements to be made for the destruction of the transmission, or its return at our cost. No liability is accepted for any unauthorised use of the information contained in this transmission.