mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
90 stars 158 forks source link

Moodle 4.0 | PHP 7.4 Strange behavior when building a template #500

Closed gemguardian closed 1 year ago

gemguardian commented 2 years ago

Hi Mark, i having an issue while building a template with a background image. For some reasons the background image is moving "out" of the field while adding new elements to the template.

I have created a video to show you what happens. I am thinking it is a css class that is not acting as it should but I am not sure. https://vimeo.com/714380853

Hope you can solve this puzzle for me. Thank you Gemma

Sunoyon commented 2 years ago

I am facing similar issue for version 4.0. Can anyone be kind enough to solve this issue?

alihamas575 commented 1 year ago

I have the same problem, I supported the subject with images https://github.com/mdjnelson/moodle-mod_customcert/issues/513 to explain a little more in detail. However, although the same problem has been opened before, the solution is still not found, which scared me a little.

Obviously I use this plugin very often, I need to solve this problem,

I am running an education service temel isg eğitimi that is legally compulsory in the laws of the country through my website. Our businesses with the definition of bursa osgb Companies are established and managed with an official document called OHS Services regulation.

mdjnelson commented 1 year ago

Linking #513 to this.

alihamas575 commented 1 year ago

Hello @mdjnelson , will there be an update on this topic? I don't know exactly how it works in moodle developer part. Isn't there any voluntary development here? Do you stop development because you stopped working at moodle? There are many people who need help with this, just like me. Can you help us?

mdjnelson commented 1 year ago

I am hoping someone will contribute from the community. I am no longer involved in Moodle work (I was a Moodle developer for 12 years) and work on newer technologies now. Frankly, after normal work hours I do not feel the desire to come home and do more programming. :) I am not sure how big of a fix this is - whether it's a simple CSS issue or a complete JS rewrite. I'll see if I can at least investigate at some time.

baris83 commented 1 year ago

Found out that in boost theme the tiny scrollbar on the right of the page causing the problem. I've added a line of css code and now working as expected.

#page-mod-customcert-rearrange #page.drawers { overflow-y: initial; }

alihamas575 commented 1 year ago

Hello Mr. Barış, how did you solve this problem did you do a manual update?

Or is this problem fixed in the new update of moodle?

baris83 commented 1 year ago

Oh sorry, i've a custom child theme based on boost theme, but you can also add that css line to "Site administration > Appearance > Additional HTML" "Within HEAD" section. But this time wrap it with style tag as shown below. Remember to purge cache after adding that line. Hope this helps <style>#page-mod-customcert-rearrange #page.drawers { overflow-y: initial; }</style>

abautu commented 1 year ago

Oh sorry, i've a custom child theme based on boost theme, but you can also add that css line to "Site administration > Appearance > Additional HTML" "Within HEAD" section. But this time wrap it with style tag as shown below. Remember to purge cache after adding that line. Hope this helps <style>#page-mod-customcert-rearrange #page.drawers { overflow-y: initial; }</style>

This did not work for me.

abautu commented 1 year ago

I found the problem to be created by the two issues:

You can see these issues here: https://user-images.githubusercontent.com/4072355/205483443-c8a2c7a4-3434-4767-8987-ccd8dc9bcde0.mp4

This patch is included in the linked pull request.

I tested this in Moodle 4.0.5 and with this fix everything work correct (ref #495).

mdjnelson commented 1 year ago

Pulled in @abautu patch and pushed, releasing in plugins DB now.