search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
90 stars 158 forks source link

feat: fix: Error thrown when we have custom profile fields #517

Closed kelsoncm closed 1 year ago

kelsoncm commented 1 year ago

Hi, @mdjnelson !

This error occurs because when there a mandatory field in the users profile, the JOINs with the 'user custom field' table's must be included. As Moodle already has the solution ready for this, in this patch I used the native solution..

I hope it helps.

See: https://github.com/mdjnelson/moodle-mod_customcert/issues/512

mdjnelson commented 1 year ago

Thanks for your work on this. Will merge when I am at my computer.

mdjnelson commented 1 year ago

Computer wasn't playing nice but all sorted now with new battery (I hope). Will get this done tonight (Perth time).

mdjnelson commented 1 year ago

Sorry I am not sure why I closed this. Getting confused from all the similar issues.

mdjnelson commented 1 year ago

I pushed this commit to 4.0. However, this was already fixed by https://github.com/mdjnelson/moodle-mod_customcert/issues/465 but this SQL is nicer which is why I am using it now.