search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
93 stars 159 forks source link

groupname update #543

Open koenraad26 opened 1 year ago

koenraad26 commented 1 year ago

I've updated the groupname element groupname.zip

mdjnelson commented 1 year ago

Can you please create a merge request instead of providing a zip? That way you will get the credit you deserve in the git history. :) Thanks.

koenraad26 commented 1 year ago

Hello Mark,

First i have to follow a course how to use github. :)

Op do 1 jun 2023 om 07:07 schreef Mark Nelson @.***>:

Can you please create a merge request instead of providing a zip? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/mdjnelson/moodle-mod_customcert/issues/543#issuecomment-1571346471, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUT2NMY5HXO52BZ7JXA3GDXJAPQRANCNFSM6AAAAAAWBD4NGQ . You are receiving this because you authored the thread.Message ID: @.***>

mdjnelson commented 1 year ago

Well, Github is just using Git, so if you know Git I can help you create a MR if you would like. Otherwise, I can just look at the code in the zip and include if it is appropriate. Is it a separate element?

koenraad26 commented 1 year ago

Hello Mark,

You may include it.

After the summer i start a course git/GitHub.

Thx.

Op zo 4 jun. 2023 23:31 schreef Mark Nelson @.***>:

Well, Github is just using Git, so if you know Git I can help you create a MR if you would like. Otherwise, I can just look at the code in the zip and include if it is appropriate. Is it a separate element?

— Reply to this email directly, view it on GitHub https://github.com/mdjnelson/moodle-mod_customcert/issues/543#issuecomment-1575740301, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUT2NNYUR6LVBRKO7PAUCTXJT5BPANCNFSM6AAAAAAWBD4NGQ . You are receiving this because you authored the thread.Message ID: @.***>

mdjnelson commented 8 months ago

Can you please tell me what this update is about and why it is being made?

koenraad26 commented 8 months ago

Hello Mark,

a customer of my wants the groupnames of student on the certificate. You can now add groupname as element.

mdjnelson commented 8 months ago

What name and email would you like to be assigned to the commit? I am not looking at this now but will do in the future if I get time and can do the git work for you if you really don't want to.

koenraad26 commented 8 months ago

Hello Mark

I did the git course. I Will add it soon.

Greetz

Op do 25 jan 2024 16:32 schreef Mark Nelson @.***>:

What name and email would you like to be assigned to the commit? I am not looking at this now but will do in the future if I get time and can do the git work for you if you really don't want to.

— Reply to this email directly, view it on GitHub https://github.com/mdjnelson/moodle-mod_customcert/issues/543#issuecomment-1910446777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUT2NMQPIW2BZS74YEWIWDYQJ3JRAVCNFSM6AAAAAAWBD4NGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGQ2DMNZXG4 . You are receiving this because you authored the thread.Message ID: @.***>

mdjnelson commented 8 months ago

Ahh congratulations @koenraad26, useful skill to know. :) Soon you can fix all the bugs in this plugin and take over from me! :D

mdjnelson commented 7 months ago

Ping @koenraad26 :)