search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
89 stars 157 forks source link

Maybe there should only be one background image #550

Closed Julian-Tovar closed 6 months ago

Julian-Tovar commented 1 year ago

Good day team.

I've been working on mod_certificate, and I was asked to code it in such a way that only one background image can be added.

So that my code doesn't fully go to waste, and maybe it can be used here, I wanted to ask, does this make sense? I think it does, because when you add a second or third background images, they stack on top of each other and hide the backgrounds below. Besides, if the user wants to compose images, they can always add an "Image" element to the certificate, to put images on top of the background image (those images can then be moved and their size can be changed).

mdjnelson commented 1 year ago

Ignore my previous comment. It's a sane idea just the PR needs adjusting. I left a comment there.

Link to PR - https://github.com/mdjnelson/moodle-mod_customcert/pull/553

mdjnelson commented 6 months ago

Closing. We may have a certificate with multiple pages and different backgrounds for each.

mdjnelson commented 6 months ago

To make this sane we would have to add a check in customcertelement_bgimage::can_add() to check what page it was being added to and to also check if a bgimage existed. IMO it's too much effort.