search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
89 stars 157 forks source link

Moodle 4.2 PHP 8.0.28 deprecation warning #555

Closed Hootie298 closed 1 year ago

Hootie298 commented 1 year ago

The following warning is appearing in our log:

AH01071: Got error 'PHP message: PHP Notice: The boolean $primary is deprecated and replaced by $type, use single_button::BUTTON_PRIMARY or self::BUTTON_SECONDARY instead

line 137 of /mod/customcert/view.php: call to single_button->__construct()

mdjnelson commented 1 year ago

Thanks! I'll take a look at this shortly. Hopefully I can create a fix in 4.0 and wont need to create a separate branch for 4.2

mdjnelson commented 1 year ago

Seems this will require a new branch unfortunately.

mdjnelson commented 1 year ago

Fixed in a new 4.2 branch. Thanks for the report.

Hootie298 commented 1 year ago

Thanks very much! Customcert is a brilliant plugin and I'm pleased to see it being so well maintained.

mdjnelson commented 1 year ago

I am glad you find this plugin useful. I will be releasing a new version with the fix on the download page in a few days, or you can just use the MOODLE_402_STABLE branch on git.

Hootie298 commented 1 year ago

Thank you - I downloaded the 402 branch a couple of days ago, installed, tested and and no issues encountered.