search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
89 stars 157 forks source link

Recipients list missing issued certificates #560

Open james-cnz opened 1 year ago

james-cnz commented 1 year ago

Hi Mark,

I was confused recently, looking at the recipients list shown in the certificate, and not being able to find some recipients listed in another report. Looking into it, it seems that this is intentional. Certificates issued to users who now have the capability to manage certificates aren't listed, presumably because they are no longer eligible to receive a certificate. I think this is unintuitive behaviour though. I think the recipients list should include everyone who's been issued a certificate, even if they are now no longer eligible to receive one.

SwennenLaura commented 1 year ago

We are experiencing the same issue (our own platform + with all our clients). The report 'issued certificates' is empty, although there are certificates issued already. Any update on this issue?

mdjnelson commented 4 months ago

I unenrolled a user from the course and refreshed the list of issued certificates and the user was still displayed. However, if you delete the user completely from the site they will not appear. So, this part seems to work as expected. I then enrolled the admin as a student and checked that they were issued a certificate when I ran the cron job and they were not. I then hacked the database to issue the admin a certificate and they were still not listed. So two things to consider -

  1. Actually issue anyone with the mod/customcert:receiveissue a certificate.
  2. Display anyone who has an issue in the table in the row.

The problem with making these changes is that people who are used to the behaviour now are going to upgrade and end up with a bunch of people getting issued certificates. I need to think about this.

mdjnelson commented 4 months ago

I see https://github.com/mdjnelson/moodle-mod_customcert/issues/376 is what introduced the logic of not sending the certificate to anyone that can manage.