search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
89 stars 157 forks source link

Adding a Monologo #568

Closed matthiasAtFernUni closed 1 month ago

matthiasAtFernUni commented 1 year ago

Could you please add a moodle 4 monologo?

danowar2k commented 8 months ago

We'd like one, too.

danowar2k commented 8 months ago

Also necessary: The function in lib.php with which the colors for the activity icon are determined (FEATURE_MOD_PURPOSE)

mdjnelson commented 5 months ago

Sorry I am out of the loop on this one. Not sure what a mono logo is (remember I don't work at Moodle anymore and just try and keep this up-to-date in free time). I am happy to look at a peer review or code change. Thanks!

mdjnelson commented 5 months ago

Please see https://moodle.org/mod/forum/discuss.php?d=455203.

mwreichel commented 1 month ago

Hi, we created for our moodle installations a monologo for mod_customcert for 4.0 as well as for the further change with 4.4. I'm not used doing a pull request in github, but I'd like to share both with you, so that the new icons will be available.

FYI: Up to 4.3 it was necessary to have the monologo as SVG and PNG, with 4.4 the new monologo is only used as SVG, therefore a general change with this version would be necessary?!

All the best, Martin

monologo_mod_customcert_4.0.zip monologo_mod_customcert_4.4.zip

mdjnelson commented 1 month ago

Thanks @mwreichel! I'll get these introduced shortly.

mwreichel commented 1 month ago

Great, thanks. You're welcome. :-)

mdjnelson commented 1 month ago

Not sure if ill need a new branch, cause it must just ignore it but still work. Ill test.

mdjnelson commented 1 month ago

Ah, looks like it will as they are different icons.

mdjnelson commented 1 month ago

Done. Need to fix a few things now since I created two new branches for 4.3 and 4.4 (I was delaying this as long as possible). Behat is failing in 4.4 for whatever reason but the icons have been cherry-picked. I authored them as "Martin W. Reichel martin.w.reichel@univie.ac.at". Thanks!

mdjnelson commented 1 month ago

Forgot to set FEATURE_MOD_PURPOSE, done now. :)