search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
89 stars 155 forks source link

Issue #531: Email task performance improvements and time limit #596

Closed Peterburnett closed 1 month ago

Peterburnett commented 5 months ago

Closes #531

Peterburnett commented 5 months ago

Hi @mdjnelson, just checking in on this one, and if you had any feedback. I can deploy on a fork, but I would rather not where it can be avoided.

It would be ideal if I could include this in my next client deployment in 2-3 weeks

mdjnelson commented 3 months ago

Sorry @Peterburnett i've been focusing on other issues and am free to look now. Also, please see there is another improvement for this at https://github.com/mdjnelson/moodle-mod_customcert/pull/610. Feel free to have a look and comment with what you think. :)

mdjnelson commented 3 months ago

Hi Peter,

I don't think it is safe to assume just because the user accessed the course after the last time the task was run that they would have necessarily downloaded the certificate.

What are your thoughts?

mdjnelson commented 1 month ago

Closing this in favour of https://github.com/mdjnelson/moodle-mod_customcert/pull/610 and due to my comments above.