search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
89 stars 155 forks source link

Missing subplugintype_customcertelement string #615

Closed ewallah closed 2 months ago

ewallah commented 2 months ago 
vendor/bin/phpunit --colors --no-coverage --testsuite tool_dataprivacy_testsuite,tool_policy_testsuite,core_privacy_testsuite
Moodle 4.4+
Php: 8.2.18
PHPUnit 9.6.18 by Sebastian Bergmann and contributors.

.............................................................   61 / 1999 (  3%)
.............................................................  122 / 1999 (  6%)
.............................................................  183 / 1999 (  9%)
.............................................................  244 / 1999 ( 12%)
.............................................................  305 / 1999 ( 15%)
.............................................................  366 / 1999 ( 18%)
.............................................................  427 / 1999 ( 21%)
.............................................................  488 / 1999 ( 24%)
.............................................................  549 / 1999 ( 27%)
.............................................................  610 / 1999 ( 30%)
.............................................................  671 / 1999 ( 33%)
.............................................................  732 / 1999 ( 36%)
.............................................................  793 / 1999 ( 39%)
.............................................................  854 / 1999 ( 42%)
.............................................................  915 / 1999 ( 45%)
.............................................................  976 / 1999 ( 48%)
............................................................. 1037 / 1999 ( 51%)
............................................................. 1098 / 1999 ( 54%)
............................................................. 1159 / 1999 ( 57%)
............................................................. 1220 / 1999 ( 61%)
............................................................. 1281 / 1999 ( 64%)
............................................................. 1342 / 1999 ( 67%)
............................................................. 1403 / 1999 ( 70%)
............................................................. 1464 / 1999 ( 73%)
............................................................. 1525 / 1999 ( 76%)
............................................................. 1586 / 1999 ( 79%)
............................................................. 1647 / 1999 ( 82%)
............................................................. 1708 / 1999 ( 85%)
............................................................. 1769 / 1999 ( 88%)
............................................................. 1830 / 1999 ( 91%)
............................................................. 1891 / 1999 ( 94%)
..........................................................EEE 1952 / 1999 ( 97%)
...............................................               1999 / 1999 (100%)

Time: 01:10.610, Memory: 149.00 MB

There were 3 errors:
tool_dataprivacy\metadata_registry_test::test_get_registry_metadata_count
tool_dataprivacy\metadata_registry_test::test_get_registry_metadata_null_provider_details
tool_dataprivacy\metadata_registry_test::test_get_registry_metadata_provider_details

Unexpected debugging() call detected.
Debugging: Invalid get_string() identifier: 'subplugintype_customcertelement' or component 'mod_customcert'. Perhaps you are missing $string['subplugintype_customcertelement'] = ''; in mod/customcert/lang/en/customcert.php?
mdjnelson commented 2 months ago

Thanks for the report.

Damn, this only affects 4.4. I dont have a branch for 4.3 or 4.4 as I was hoping the 4.2 branch would be maintainable for a while. I could just add the string to the 4.2 branch instead of creating a new branch. Ill think abt it.

ewallah commented 2 months ago

I would go for adding the string to the 4.2 branch, you never know if the metadata registry tests also arrive in 4.2 and 4.3...

mdjnelson commented 2 months ago

Strange. I did a git blame on main for the file admin/tool/dataprivacy/tests/metadata_registry_test.php and see it was last updated in https://tracker.moodle.org/browse/MDL-73971 but that was applied for 3.11 onwards. Not sure why it is appearing in 4.4 now ...

mdjnelson commented 2 months ago

Added the strings there as they are present in 4.1 and 4.2 as valid strings in other components. Thanks.