search

mdjnelson / moodle-mod_customcert

Enables the creation of dynamically generated certificates with complete customisation via the web browser.
https://moodle.org/plugins/mod_customcert
GNU General Public License v3.0
94 stars 160 forks source link

Adapt mobile code to ionic 7 #631

Closed dpalou closed 4 months ago

dpalou commented 4 months ago

In this PR I'm removing the ionic3 code (the ionic5 app was released on 2021 so it should be safe to remove it).

I also created a new latest template to use the new Ionic syntax for ion-select. The old syntax still works in the 4.4 version of the app (ionic 7), but it will stop working in the 4.5 version (ionic 8) and the ion-select would be wrongly aligned without these changes. To make it easier to review the code, in the first commit I duplicate the template (no changes done in the HTML) and then I apply the changes in a new commit.

Finally, I also removed the core-course-module-description component, it is deprecated and will be removed in a future version of the app. It should have been removed already, but we kept it in the app because some plugins still use it.

mdjnelson commented 4 months ago

Thanks @dpalou, really appreciate you helping with the mobile app side of things. :) Do we force users to update the Moodle app, that would avoid issues with users on an older version? Also, would it be safe to backport to 4.1 as well?

dpalou commented 4 months ago

Hi Mark! Users can choose whether to update the app or not, we don't force them. Also, our branded apps (and custom apps made by the community) take a while to be updated, so we'll have to keep the ionic 5 template in there for a while.

I just tested this in a 4.1 site and it seems to work fine, so it should be safe to backport, yes. Will you do it or should I create different Pull Requests?

mdjnelson commented 4 months ago

Thanks @dpalou! I can do the backport so no worries. :)