search

mdlayher / vsock

Package vsock provides access to Linux VM sockets (AF_VSOCK) for communication between a hypervisor and its virtual machines. MIT Licensed.
MIT License
336 stars 65 forks source link

add ListenLocal for ease of testing #43

Closed rockmenjack closed 2 years ago

rockmenjack commented 3 years ago

Per https://man7.org/linux/man-pages/man7/vsock.7.html, CID=0x1 can be thought as a loopback cid for local communication. Adding the function for listening on CID=0x1 can make testing much simpler which is in my use case....Any thoughts?

rockmenjack commented 3 years ago

seems listen is not allowed in CI env

mdlayher commented 3 years ago

Thank you for the PR and I apologize for the delay: I am mostly on hiatus from open source software development at the moment. However I intend to address this and the other outstanding PRs as part of #45 and will follow up once I'm able to do so. Thanks again.

mdlayher commented 2 years ago

Thank you again for your time. I have incorporated a version of this using vsock.ListenContextID in v1.0.0 where you can choose to bind to vsock.Local if you wish.

rockmenjack commented 2 years ago

that's 👍

On Sat, Feb 5, 2022, 04:23 Matt Layher @.***> wrote:

Thank you again for your time. I have incorporated a version of this using vsock.ListenContextID in v1.0.0 where you can choose to bind to vsock.Local if you wish.

— Reply to this email directly, view it on GitHub https://github.com/mdlayher/vsock/pull/43#issuecomment-1030322640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5E26BXYUFAIMHOOVHDUW3UZQYUNANCNFSM45IG53RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>