mdmintz / pynose

pynose fixes nose to extend unittest and make testing easier
https://pypi.org/project/pynose/
GNU Lesser General Public License v2.1
11 stars 6 forks source link

Replace deprecated imp module with importlib #1

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

mdmintz commented 1 year ago

@hugovk where do you see import imp in this codebase? The pynose repo already fixed the issues of the older nose repo.

hugovk commented 1 year ago

It's here:

https://github.com/mdmintz/pynose/blob/4e0d2bb475cdf46577c66b6dea9923877ccb09e6/nose/importer.py#L10

https://github.com/mdmintz/pynose/blob/4e0d2bb475cdf46577c66b6dea9923877ccb09e6/nose/importer.py#L65-L81

mdmintz commented 1 year ago

Fixed in 1.4.3 - https://github.com/mdmintz/pynose/releases/tag/v1.4.3