search

mdmintz / pynose

pynose fixes nose to extend unittest and make testing easier
https://pypi.org/project/pynose/
GNU Lesser General Public License v2.1
14 stars 6 forks source link

Add Python 3.12 to the testing #13

Closed cclauss closed 10 months ago

mdmintz commented 10 months ago

Hello, @cclauss.

Your PR dropped testing from Python versions that were still being supported, even if they were old versions on life-support. I added CI testing of 3.12 in a recent commit, which is probably what you wanted anyway. See https://github.com/mdmintz/pynose/blob/master/.github/workflows/python-package.yml for the latest version of that.

python-package-legacy.yml will be removed as soon as support for Python 3.6 is fully dropped, so that doesn't need to be updated.

Also, -U is a shortcut for --upgrade, so your change to use the longer version in CI doesn't serve a purpose. Save opinionated changes like that for maintainers.

cclauss commented 10 months ago

No problems... I was just pushing for Python 3.12 which you got in your PR so I was happy to close this one.

pip install currently has six different --u* options so I encourage a self-documenting approach in scripts read by others.

% pip install --help | grep "\-\-u"

  --user                      Install to the Python user install directory for
  -U, --upgrade               Upgrade all specified packages to the newest
  --upgrade-strategy <upgrade_strategy>
  --use-pep517                Use PEP 517 for building source distributions
  --use-feature <feature>     Enable new functionality, that may be backward
  --use-deprecated <feature>  Enable deprecated functionality, that will be