mdmintz / pynose

pynose fixes nose to extend unittest and make testing easier
https://pypi.org/project/pynose/
GNU Lesser General Public License v2.1
11 stars 6 forks source link

Keep GitHub Actions up to date with GitHub's Dependabot #17

Closed cclauss closed 7 months ago

cclauss commented 7 months ago

Automatically creates pull requests to upgrade GitHub Actions which will remove the warning like at the bottom right of https://github.com/mdmintz/pynose/actions/runs/7873191347

mdmintz commented 7 months ago

.github/workflows/python-package.yml has already been updated to use the newer versions.

.github/workflows/python-package-legacy.yml is expected to have those deprecation warnings because Python 3.6 is already deprecated, and we're keeping support for that anyway, at least until GitHub Actions drops support for Python 3.6 entirely.

Definitely no Dependabot, as that creates unnecessary noise for things that are already known.

cclauss commented 7 months ago

The Actions updates have nothing to do with the versions of Python that can be used. That is governed not by the actions but by the version of Ubuntu, macOS, or Windows used and the https://github.com/actions/python-versions file.

I agree that Dependabot can be chatty to PyPI or npm, etc. dependencies but Actions do not receive major updates often. Reduction of chattiness was handled in this PR by bundling all Actions updates into a single PR (so max one new PR a week) but the interval could be set to monthly (so max one new PR a month -- not chatty but at least automatic).

mdmintz commented 7 months ago

The newer Actions versions don't fully support Python 3.6: https://github.com/mdmintz/pynose/actions/runs/4308067130/job/11698879866

See https://github.com/actions/setup-python/issues/544 for more info.

That's the whole reason why the original Actions job got split into two in the first place:

cclauss commented 7 months ago

If you drop back from runs-on: ubuntu-latest to ubuntu-20.04 you will be able to test on Py3.5 and Py3.6 even on the latest action.

mdmintz commented 7 months ago

I updated to actions/setup-python@v5: https://github.com/mdmintz/pynose/commit/8d612ee5621e81494598f940a96171c2b7b67f1b The warning message went away. All set.