mdmintz / pynose

pynose fixes nose to extend unittest and make testing easier
https://pypi.org/project/pynose/
GNU Lesser General Public License v2.1
14 stars 6 forks source link

Restore original LGPL license #30

Closed cbodley closed 4 months ago

cbodley commented 4 months ago

restores the original license from https://github.com/nose-devs/nose

replacing the MIT license requires sign-off from the two copyright holders:

cbodley commented 4 months ago

proposed resolution to https://github.com/mdmintz/pynose/issues/16. requesting approvals from @mdmintz @cclauss

mdmintz commented 4 months ago

@cbodley Please fix flake8 issues. Lines have a 79-char limit.

mdmintz commented 4 months ago

@cbodley Still flake8: E131 continuation line unaligned for hanging indent

emilazy commented 4 months ago

Thanks for this PR. I would recommend restoring the AUTHORS file and adding the two new ones, as currently there is no adequate attribution of copyright.

cbodley commented 4 months ago

@mdmintz @cclauss thanks very much for the speedy reviews!

cbodley commented 4 months ago

Thanks for this PR. I would recommend restoring the AUTHORS file and adding the two new ones, as currently there is no adequate attribution of copyright.

@emilazy this is probably worth creating a separate issue for

mdmintz commented 4 months ago

Merged!

emilazy commented 4 months ago

Thank you for addressing the licensing concerns.

Thanks for this PR. I would recommend restoring the AUTHORS file and adding the two new ones, as currently there is no adequate attribution of copyright.

@emilazy this is probably worth creating a separate issue for

Looks like there’s https://github.com/mdmintz/pynose/pull/31 now. Thanks for putting in work here; I was just considering it in the context of general licence/copyright compliance.

mdmintz commented 4 months ago

The AUTHORS file has been added too.