Closed cbodley closed 4 months ago
proposed resolution to https://github.com/mdmintz/pynose/issues/16. requesting approvals from @mdmintz @cclauss
@cbodley Please fix flake8 issues. Lines have a 79-char limit.
@cbodley Still flake8
:
E131 continuation line unaligned for hanging indent
Thanks for this PR. I would recommend restoring the AUTHORS
file and adding the two new ones, as currently there is no adequate attribution of copyright.
@mdmintz @cclauss thanks very much for the speedy reviews!
Thanks for this PR. I would recommend restoring the
AUTHORS
file and adding the two new ones, as currently there is no adequate attribution of copyright.
@emilazy this is probably worth creating a separate issue for
Merged!
Thank you for addressing the licensing concerns.
Thanks for this PR. I would recommend restoring the
AUTHORS
file and adding the two new ones, as currently there is no adequate attribution of copyright.@emilazy this is probably worth creating a separate issue for
Looks like there’s https://github.com/mdmintz/pynose/pull/31 now. Thanks for putting in work here; I was just considering it in the context of general licence/copyright compliance.
The AUTHORS file has been added too.
restores the original license from https://github.com/nose-devs/nose
replacing the MIT license requires sign-off from the two copyright holders: