search

mdmintz / pynose

pynose fixes nose to extend unittest and make testing easier
https://pypi.org/project/pynose/
GNU Lesser General Public License v2.1
11 stars 6 forks source link

Fix support for 3.11 #5

Closed adiroiban closed 1 year ago

adiroiban commented 1 year ago

Fixes #4

This updated the test suite for 3.11 and tries to fix any 3.11 isssue

adiroiban commented 1 year ago

I am waiting for CI to kick in and then I will push the fix and release notes changes

mdmintz commented 1 year ago

Already resolved by https://github.com/mdmintz/pynose/pull/6

Also, this PR is incorrectly titled, as it only changes tests... it does not actually resolve the issue. Will be keeping the tests as is to minimize the code of the repo.

adiroiban commented 1 year ago

Well... I had the other changes written on my local branch, but I haven't pushed those commits as I wanted to see the CI red.

I am a bit disappointed with having the fix merged without any automated tests.

But not a big deal. This is your repo so I am ok with this. No hard feelings.