search

mdmparis / defense-finder

Systematic search of all known anti-phage systems.
GNU General Public License v3.0
73 stars 12 forks source link

Draft: Add functional test #35

Closed bryan-brancotte closed 7 months ago

jeanrjc commented 9 months ago

I modified the way get the model's version, the way you did it triggered the full macsyfinder's log. I also filter out other potential models that would be installed by the user

jeanrjc commented 9 months ago

There is a bug with coverage, I don't understand it. I have a different one on my laptop with coverage (ImportError: cannot import name 'TooledTest' from 'tests'). But the test passes with pytest.

The problem was 2 folds :

  1. There was new systems or new names
  2. The numbering of the system was shifted because of the new names.

The 1 is important to capture, but not the 2 which add noise to the output and makes it harder to quickly pinpoint what is actually different. Maybe we could drop the column sys_id or at least strip the number at the end.

bryan-brancotte commented 9 months ago

Hi @jeanrjc

I droppped the sys_id column in ed87285e58560b527c85c295b855fa8d4bb1e698, quicker than using regexp to strip then end (but doable)

jeanrjc commented 8 months ago

I thought this one was merged, but not ! Is there anything missing ?

bryan-brancotte commented 8 months ago

Hi, data in expected_results folders have to be updated so when the tests runs, results are the same. For the reste I think we are good (ignoring a specific column done, and case sensible comparison done to)