mdmparis / defense-finder

Systematic search of all known anti-phage systems.
GNU General Public License v3.0
73 stars 12 forks source link

Inconsistencies between versions and local VS webserver results. #38

Closed TaraBartolec closed 4 months ago

TaraBartolec commented 9 months ago

Hi Defense-Finder team,

Firstly, thanks for making such a great tool.

I recently updated my defense-finder models to the latest release (v1.2.3) and am getting conflicting results across versions and also on the webserver. The main problem is a missing system (Mokosh Type II) in version 1.2.3 installed locally, that comes up in the old version and also on the current webserver implementation.

Would it be possible to get some help to understand what is going on? Is it an issue of different versions on the webserver implementation? Why would a system disappear across versions?

I have uploaded an example nucleotide fasta and protein fasta (generated by Prodigal defaults). The problem persists no matter which format I start the Defense-Finder analysis in. https://oc.embl.de/index.php/s/VewAdfSzLBd8FHh The problem is described in more detail below.

Best, Tara

The version I installed locally on my computer and ran in March (not sure which version exactly) produced the following systems:

Recent version 1.2.3 run locally produces:

Webserver (I am not sure which version) produces):RM

Mokosh Type II disappears in the newest version of defense-finder. Gabija and MazEF also appear variable.

jeanrjc commented 9 months ago

Hello,

We adapted the models and coverage thresholds and newer versions of the models should be the one to keep. It does not mean that older results are wrong, it's just that given our current knowledge, those hits now appear less likely. Depending on your research question you can chose to keep working with them or not.

The webservice is currently being updated, and should contain the new models and defense finder version with the upcoming release (stay tuned, it will be there : defensefinder.mdmlab.fr, currently redirecting to the old version).

github-actions[bot] commented 6 months ago

Stale issue message

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days and is now marked as stale. It will be closed in 7 days without further activity.