search

mdn / browser-compat-data

This repository contains compatibility data for Web technologies as displayed on MDN
https://developer.mozilla.org
Creative Commons Zero v1.0 Universal
4.91k stars 1.97k forks source link

engine_version should be a required field in browser releases #22843

Open lukewarlow opened 5 months ago

lukewarlow commented 5 months ago

What type of issue is this?

Schema issue

What is the issue?

Currently it's possible to add a browser release without adding an engine_version field.

What behavior were you expecting?

engine_version should be a required field as it's a prerequisite for mirroring to work.

What version(s) of BCD is the issue present in?

Do you have anything more you want to share?

The lack of schema validation for this field led to issues with chrome data not mirroring to edge for the latest releases (see https://github.com/mdn/browser-compat-data/pull/22842), it also led to a data issue where edge was given an explicit value rather than mirroring (also fixed in that PR).

Elchi3 commented 5 months ago

Yeah, I think this would be great. We do have some historical data for Internet Explorer and Opera for which we haven't stored an engine_version. Would be good to require it for everything else, though. And indeed, mirroring needs this information.