search

mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9.15k stars 22.47k forks source link

Remove notranslate from code samples in Writing Guidelines #1822

Closed Ryuno-Ki closed 3 years ago

Ryuno-Ki commented 3 years ago

https://github.com/mdn/content/blob/ec7a60ae626b0253c8eb1570c39251922b13e4d4/files/en-us/mdn/guidelines/writing_style_guide/index.html

contains several notranslate classes in <pre> elements, which can be safely removed, because they will get added back on build time using Yari.

dk-github-acc commented 3 years ago

Hello sir As a beginner, I would like to complete this task.

Ryuno-Ki commented 3 years ago

Do it! Looking forward to your first PR :-)

Let us know if you need help with something!

dhananjayd1729 commented 3 years ago

Hey @Ryuno-Ki , this issue is closed right ? (Though I was able to find out 'notranslate' class in pre.)

hamishwillee commented 3 years ago

Yes. There was a global change some weeks ago to remove these (and you can see it is gone in head revision

@dhananjayd1729 Even so, thanks so much for offering to help. Plenty more things to fix :-)

Ryuno-Ki commented 3 years ago

Thanks for closing, @hamishwillee. Got quite swamped lately over here :-(