mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9.13k stars 22.45k forks source link

BiquadFilterNode»Q: Incorrect range for Q? #23592

Open ElizabethHudnott opened 1 year ago

ElizabethHudnott commented 1 year ago

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/BiquadFilterNode/Q

What specific section or headline is this issue about?

The first section. No subheading.

What information was incorrect, unhelpful, or incomplete?

"It is a dimensionless value with a default value of 1 and a nominal range of 0.0001 to 1000."

What did you expect to see?

According to the W3C document this article links to, the range of Q is +/-770.63678 for lowpass and highpass filters and [0,3.4028235e38] for bandpass, notch and peaking filters and for lowpass and highpass filters the units are decibels, so it's not dimensionless in those cases. Where are the 0.0001 and 1000 values stated in this article derived from?

Do you have any supporting links, references, or citations?

https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-q

Do you have anything more you want to share?

No response

MDN metadata

Page report details * Folder: `en-us/web/api/biquadfilternode/q` * MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/BiquadFilterNode/Q * GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/api/biquadfilternode/q/index.md * Last commit: https://github.com/mdn/content/commit/8fd76eb81b57c66405db132e361380d812d550b4 * Document last modified: 2022-10-07T16:44:44.000Z
wbamberg commented 1 year ago

Thank you for filing! It looks like these came from an old version of the spec: https://www.w3.org/TR/2015/WD-webaudio-20151208/#attributes-26 .

According to the W3C document this article links to, the range of Q is +/-770.63678 for lowpass and highpass filters and [0,3.4028235e38] for bandpass, notch and peaking filters and for lowpass and highpass filters the units are decibels, so it's not dimensionless in those cases.

This looks right to me, would you like to file a PR to update the page (no worries if you don't, we will take care of it).