mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9.17k stars 22.46k forks source link

"Define your app icons" uses themed icons for its maskable icon example, rather than shaped adaptive icons #28681

Closed NotWoods closed 1 year ago

NotWoods commented 1 year ago

MDN URL

https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/How_to/Define_app_icons

What specific section or headline is this issue about?

Support masking

What information was incorrect, unhelpful, or incomplete?

The Android screenshot showcases a homescreen using monochrome icons, not maskable icons. But while monochrome icons are specced, they haven't been implemented in Chrome yet for homescreen icons. (Only for shortcut icons in Android and Chrome OS.)

The Android 13 home screen, showing circular and color themed app icons

On Android, "adaptive icons" refers to icons adapting to both shape and color. Maskable icons correspond to different shapes, whereas monochrome icons correspond to color selection.

What did you expect to see?

I figure the docs should either:

Do you have any supporting links, references, or citations?

Do you have anything more you want to share?

Monochrome icon support is a bit difficult to represent right now. Last I checked,

captainbrosset commented 1 year ago

Thanks @NotWoods for the report and providing as much details. I'll take a crack at this now.

captainbrosset commented 1 year ago

Thinking about it some more, I'm of the opinion that we should go with your first approach: remove mentions of themes, remove the unrelated screenshot, and make sure this section is purely about masks. As for adding another section about monochrome, I don't think we should do it, since it's not supported anywhere yet. I'll provide a PR soon.