search

mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
8.88k stars 22.43k forks source link

correct document picture-in-picture example #33293

Closed joshfarrant closed 1 week ago

joshfarrant commented 3 weeks ago

Description

Correct mistake in Document Picture-in-Picture API example and improve clarity of docs.

Motivation

I copy/pasted the current example and it didn't work, so I've tweaked the example a bit to both fix it, and hopefully make it clearer.

Additional details

N/A

Related issues and pull requests

github-actions[bot] commented 3 weeks ago

Preview URLs

External URLs (1) URL: [`/en-US/docs/Web/API/Document_Picture-in-Picture_API/Using`](https://pr33293.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document_Picture-in-Picture_API/Using) Title: `Using the Document Picture-in-Picture API` - (2 times) (Note! This may be a new URL 👀)

(comment last updated: 2024-05-08 16:48:07)

joshfarrant commented 1 week ago

@wbamberg Thanks for the response and detailed comments 💖

I've updated the incorrect link in 05b67eb4359f387197cb353d389a01275204c7a9 and I've opened a PR on the dom-examples repo here https://github.com/mdn/dom-examples/pull/274

Let me know if I've missed anything 🙂

joshfarrant commented 1 week ago

https://github.com/mdn/dom-examples/pull/274 has been merged