mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
8.88k stars 22.42k forks source link

Add hasUnpartitionedCookieAccess #33329

Open arichiv opened 3 weeks ago

arichiv commented 3 weeks ago

Description

This is the first of 3 PRs adding spec changes from https://privacycg.github.io/saa-non-cookie-storage/ launching in Chrome 125.

Motivation

hasUnpartitionedCookieAccess is a renaming of hasStorageAccess intended to provide more clarity around what storage is actually accessible. This is important as Chrome now supports requesting unpartitioned storage access with or without unpartitioned cookies.

Additional details

https://chromestatus.com/feature/5175585823522816

Related issues and pull requests

Relates to https://github.com/mdn/mdn/issues/543

arichiv commented 2 weeks ago

@Elchi3 @pepelsbey Have time to review?

github-actions[bot] commented 2 weeks ago
Preview URLs (6 pages) - [`/en-US/docs/Web/API/Document/hasStorageAccess`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document/hasStorageAccess) - [`/en-US/docs/Web/API/Document/hasUnpartitionedCookieAccess`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document/hasUnpartitionedCookieAccess) - [`/en-US/docs/Web/API/Document/requestStorageAccessFor`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document/requestStorageAccessFor) - [`/en-US/docs/Web/API/Document/requestStorageAccess`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document/requestStorageAccess) - [`/en-US/docs/Web/API/Document`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document) - [`/en-US/docs/Web/API/Storage_Access_API`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Storage_Access_API)
Flaws (6) Note! *5 documents with no flaws that don't need to be listed. 🎉* URL: [`/en-US/docs/Web/API/Document`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document) Title: `Document` Flaw count: 6 - **macros**: - `/en-US/docs/Web/API/Document/xmlStandalone does not exist` - `/en-US/docs/Web/API/Document/captureEvents does not exist` - `/en-US/docs/Web/API/Document/getBoxQuads does not exist` - `/en-US/docs/Web/API/Document/releaseEvents does not exist` - `/en-US/docs/Web/API/Document/queryCommandIndeterm does not exist` - *and 1 more flaws omitted*
External URLs (1) URL: [`/en-US/docs/Web/API/Document/hasUnpartitionedCookieAccess`](https://pr33329.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document/hasUnpartitionedCookieAccess) Title: `Document: hasUnpartitionedCookieAccess() method` - (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-05-21 20:59:46)

arichiv commented 2 weeks ago

@sideshowbarker I'm working on https://github.com/mdn/browser-compat-data/pull/22978 but that's paused until the new spec I added to browser-specs propagates. Can this more forward before then?

sideshowbarker commented 2 weeks ago

I'm working on mdn/browser-compat-data#22978 but that's paused until the new spec I added to browser-specs propagates. Can this more forward before then?

I think the project policy is to not merge mdn/content PRs that for features that need data that’s not yet in mdn/browser-compat-data (BCD) — the reason being that unless/until the data is in BCD, the presentation of the MDN Browser Compat table and Specifications section of the corresponding MDN page will be broken.

Specifically in this case, it seems like api.Document.hasUnpartitionedCookieAccess needs to be merged into main in BCD before this PR can be landed.

And if the BCD PR for api.Document.hasUnpartitionedCookieAccess is blocked on waiting for a new browser-specs to be deployed, I also don’t know myself how it takes for that to happen

github-actions[bot] commented 2 weeks ago

This pull request has merge conflicts that must be resolved before it can be merged.

arichiv commented 2 weeks ago

@Elchi3 @pepelsbey this is ready for review, the only flaw is that it's dependent on pulling two versions of packages newer than what's in the lockfile.

github-actions[bot] commented 6 days ago

This pull request has merge conflicts that must be resolved before it can be merged.

arichiv commented 10 hours ago

@sideshowbarker have time for review?

arichiv commented 3 hours ago

I don't have permission to merge on this or the other one, could you do so?