search

mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
8.96k stars 22.44k forks source link

Express-introduction: Broken link #34481

Closed Sokolan closed 2 hours ago

Sokolan commented 3 days ago

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction#rendering_data_views

What information was incorrect, unhelpful, or incomplete?

The provided link to the list of template engines is broken.

What did you expect to see?

working link.

Do you have any supporting links, references, or citations?

After taking a look at the express github repo it seems like they've removed the page. The same PR also removed another broken link which was mentioned here.

Do you have anything more you want to share?

No response

MDN metadata

Page report details * Folder: `en-us/learn/server-side/express_nodejs/introduction` * MDN URL: https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction * GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/learn/server-side/express_nodejs/introduction/index.md * Last commit: https://github.com/mdn/content/commit/e7d7c8739cd6315a32400e76de2ec79594e86d8a * Document last modified: 2024-06-10T14:32:11.000Z
bsmth commented 3 days ago

Thanks for reporting. We could replace with https://expressjs.com/en/guide/using-template-engines.html, what do you think?

Sokolan commented 3 days ago

That link is already provided in the end of the template section: For more information see Using template engines with Express (Express docs). I think it would be a duplication, and there's a minimal information regarding what template engines work with express (from the provided link):

Some popular template engines that work with Express are Pug, Mustache, and EJS. The Express application generator uses Jade as its default, but it also supports several others.

I'm currently studying the subject (that's why I've stumbled the broken link) so maybe I'm maybe I'm wrong about it.

hamishwillee commented 7 hours ago

Thanks. That is so annoying - we only fixed up the original link in March https://github.com/mdn/content/pull/32461/.

I'll fix this with some words about the supported versions. Note, not quite those words though, since we don't want to recommend Jade, which become Pug.

hamishwillee commented 6 hours ago

Done in #34527