search

mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9.13k stars 22.45k forks source link

Improvements to "your first form" #35917

Open Boodac opened 2 days ago

Boodac commented 2 days ago

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/Forms/Your_first_form

What specific section or headline is this issue about?

The <label>, <input>, and <textarea> elements

What information was incorrect, unhelpful, or incomplete?

The HTML snippet for using the first form doesn't make use of modern HTML form tags.

What did you expect to see?

Instead of organizing the form as an unordered list, I expected to see some use of things like fieldset, legend, optgroup, et cetera.

Previous education has led me to understand that forms are not unordered lists, and there are semantic/accessibility issues with the current tutorial.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details * Folder: `en-us/learn/forms/your_first_form` * MDN URL: https://developer.mozilla.org/en-US/docs/Learn/Forms/Your_first_form * GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/learn/forms/your_first_form/index.md * Last commit: https://github.com/mdn/content/commit/b76266228bd0900aa1256902c7858971156a58c9 * Document last modified: 2024-07-25T19:07:12.000Z
Josh-Cena commented 2 days ago

@estelle what say you?

estelle commented 2 days ago

We can change the list to four paragraphs, but we shouldn't add additional features to this page. Those are covered in later tutorials in the series.

Boodac commented 1 day ago

@estelle This seems like the best of both worlds strategy, to use some other block level delineation to format the form. Don't want to undo all the previous "use semantic tags whenever possible" learning.

The next tutorial is careful to use things like UL to organize unordered lists of options (example: radio buttons), which seems far more semantic than using a UL for the entire form. Had no problems with the later HTML 5 parts, they're well done.