mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9.18k stars 22.47k forks source link

[WebAPI] Hide fragment directives from Navigation Timing API #36546

Open hamishwillee opened 3 days ago

hamishwillee commented 3 days ago

Acceptance criteria

For folks helping with Firefox related documentation

Features to document

This needs at least a release note because the behaviour is a bugfix that unfortunately some sites are relying on. I would say a BCD entry too.

It may be reasonable to add a note to the preformance API thingy too that this is URL minus any url fragment (unrelated, but same behaviour might b recorded in https://developer.mozilla.org/en-US/docs/Web/API/Location/href

What happens is that if you use Performance.getEntries() (or the variants that take a name and type) you get an array of entries that have a particular requested type. One of the entry types is navigation so your objects are PerformanceNavigationTiming.

For these the name of each entry is a URL. The change is that now this URL will exclude the text fragment.

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1919565

Other

eligrey commented 2 days ago

the behaviour is a bugfix that unfortunately some sites are relying on.

That is incorrect. This was not a bugfix prior to Firefox supporting scroll-to-text. Transcend shipped this feature long before Firefox shipped scroll-to-text support.

I reached out to @zcorpan for more engagement on these concerns. I believe it is unjust for Mozilla to retroactively classify breaking Transcend's features as a 'bugfix', given that there was no 'bug' when we first added the feature.

zcorpan commented 1 day ago

@eligrey it was a bug fix because the behavior didn't match what the spec requires.

I'm happy to discuss more, but this issue is not the right place. Please reach out to me directly.