search

mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9k stars 22.44k forks source link

Issue with "Navigator": sidebar contains duplicated elements #7036

Closed lucacasonato closed 3 years ago

lucacasonato commented 3 years ago

MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/battery

What information was incorrect, unhelpful, or incomplete?

The sidebar contains all properties 4 times. They all link to the same pages.

image

MDN Content page report details * Folder: `en-us/web/api/navigator/battery` * MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/battery * GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/api/navigator/battery/index.html * Last commit: https://github.com/mdn/content/commit/9b648e559239b3e682abfcb15845a954d420b207 * Document last modified: 2021-05-31T17:00:38.000Z
teoli2003 commented 3 years ago

This happening on all navigator pages… {{APIRef}} is doing something weird.

lucacasonato commented 3 years ago

So Yari issue?

sideshowbarker commented 3 years ago

Yeah, this is a Yari issue — specifically, a kumascript macros issue — caused by some things having been deleted from MDN but not yet from kumascript/macros/InterfaceData.json. See https://github.com/mdn/yari/commit/02988aaf68d258a097d640357bcb60b800ce69e5 for another recent case.

sideshowbarker commented 3 years ago

Opened https://github.com/mdn/yari/pull/4252 with a fix.

teoli2003 commented 3 years ago

Thank you, completely forgot about InterfaceData! So my fault. Thanks for fixing it.

lucacasonato commented 3 years ago

Thanks folks!