mdn / content

The content behind MDN Web Docs
https://developer.mozilla.org
Other
9.18k stars 22.47k forks source link

Issue with "WebAssembly.Memory() constructor": No "shared" field in the spec #860

Closed saschanaz closed 2 years ago

saschanaz commented 3 years ago

MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory

What information was incorrect, unhelpful, or incomplete?

The document describes shared dictionary field but it's not in the spec

Specific section or headline?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory#Syntax

What did you expect to see?

A note about why it's not in spec, or just delete it.

Did you test this? If so, how?

SpiderMonkey seems to support it, didn't check Blink.

MDN Content page report details * Folder: `en-us/web/javascript/reference/global_objects/webassembly/memory/memory` * MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory * GitHub URL: https://github.com/mdn/content/blob/master/files/en-us/web/javascript/reference/global_objects/webassembly/memory/memory/index.html * Report started: 2021-01-02T17:53:51.032Z
Elchi3 commented 3 years ago

This is the spec: https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#javascript-api-changes

saschanaz commented 3 years ago

Cool, then the work item would be to add it to the spec table.

himanshugarg commented 3 years ago

As I see it, SpecData.json needs a new entry. The spec link shared by Elchi3 is specific to WebAssembly threads and the current more generic:-

 "WebAssembly JS": {
    "name": "WebAssembly JavaScript Interface",
    "url": "https://webassembly.github.io/spec/js-api/",
    "status": "WD"
  }

I am hoping that adding the following would fix it but I don't know what the name and status values should be to get the Specifications macro use this instead

 "?": {
    "name": "?",
    "url": "https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#javascript-api-changes",
    "status": "?"
  }