search

mdn / css-examples

Code examples that accompany the MDN CSS documentation
https://developer.mozilla.org/en-US/docs/Web/CSS
Creative Commons Zero v1.0 Universal
610 stars 851 forks source link

Inconsistent downloadable starting code for task #132

Open Arvton opened 1 year ago

Arvton commented 1 year ago

Downloadable starting code

learn/tasks/writing-modes/logical-width-height-download.html It differs from code shown in online editor.

Online editor code

learn/tasks/writing-modes/logical-width-height.html Should the writing-mode for the vertical class be declared inside of the editable styles area? It can be declared after the box class styles. This makes the task easier to solve too.

Arvton commented 1 year ago

Permalinks to lead to the files:

Downloadable starting code https://github.com/mdn/css-examples/blob/4970f5ac6d2726bc128233b531037d0306a9ad08/learn/tasks/writing-modes/logical-width-height-download.html

Online editor https://github.com/mdn/css-examples/blob/4970f5ac6d2726bc128233b531037d0306a9ad08/learn/tasks/writing-modes/logical-width-height.html

caugner commented 1 year ago

I agree with the OP:

  1. In the download version, the .vertical CSS rule could be moved below the .box rule here: https://github.com/mdn/css-examples/blob/4970f5ac6d2726bc128233b531037d0306a9ad08/learn/tasks/writing-modes/logical-width-height-download.html#L15-L26
  2. In the editor version, the .vertical CSS rule should be moved inside the editable block: https://github.com/mdn/css-examples/blob/4970f5ac6d2726bc128233b531037d0306a9ad08/learn/tasks/writing-modes/logical-width-height.html#L7-L23 And it also needs to be added inside the textarea: https://github.com/mdn/css-examples/blob/4970f5ac6d2726bc128233b531037d0306a9ad08/learn/tasks/writing-modes/logical-width-height.html#L32-L41
pragyamishra56 commented 9 months ago

@caugner Sir could you assign me this issue?