Closed madhuroshan closed 1 year ago
The index page reads:
The "animation-frames-timing-function" directory contains a simple example that demonstrates the difference between the steps() timing function available for CSS animations and transitions, and the new frames() timing function. Run the example live. You can also find versions that show the same timing function used with transitions, and used with the Web Animations API.
So this text is intentional. We should delete the whole example rather than edit it and the paragraph in https://github.com/mdn/css-examples/blob/main/README.md that mentions it.
Paging @chrisdavidmills, as the original author ... 6 years ago ... just to confirm.
Yes those are the changes required
We just need to reformat the code, waiting on a reply on this comment to understand how to proceed.
okay
We just need to reformat the code, waiting on a reply on this comment to understand how to proceed.
For now, I suggest you get the formatted code from this Prettier playground link.
Only change from default setting is --bracket-same-line
is set to true. And html
parser is used.
Add the formatted code and commit the changes?
Add the formatted code and commit the changes?
yes
Oops, sorry, hadn't see your last two comments!
You have added the formatted code right? So, everything is done then?
You have added the formatted code right? So, everything is done then?
Yes, all done. :)
Thank you @madhuroshan! 🎉
Thank you @caugner @chrisdavidmills
Description
In mdn/css-examples/animation-frames-timing-function/index-waa.html
In
div.animate(keyframes,options)
options object have easing function given as frames(10) but frames(10) is not a valid value of easing functions.Can't find any easing function named
frames
in mdn docs . So I replaced frames with steps (we can add others like cubic-bezier and other easing functions)changed
var easingFunctions = ["frames(10)", "steps(10)", "ease-in"];
tovar easingFunctions = ["steps(5)", "steps(10)", "ease-in"];
Fixes #145