Closed teoli2003 closed 6 days ago
@teoli2003 Sir, Could you assign me this issue? I want to fix this
You shouldn't ask this in several issues. I've already assigned the previous request to you, so start with it. Also you don't need to ask for permission, you can just create the PRs.
Thanks for raising this concern! I understand the importance of using modern syntax consistently. I'll take the initiative to update the occurrences of rgba and hsla to the modern rgb and hsl syntax throughout the repository. I'll exclude the tools directory as per your suggestion, focusing on maintaining consistency in the main codebase. Appreciate your vigilance on this matter!
Is this still an issue? I can contribute
Is this still an issue? I can contribute
For rgba
, there are the following occurrences (is CSS) excluding the tools and editable-samples dir:
For hsla, it looks like this is all:
./houdini/css_painting_api/example-boxbg.html: --boxColor: hsla(55, 90%, 60%, 1);
./houdini/css_painting_api/example-boxbg.html: --boxColor: hsla(155, 90%, 60%, 1);
./houdini/css_painting_api/example-boxbg.html: --boxColor: hsla(255, 90%, 60%, 1);
There are quite a few occurrences of
rgba
andhsla
in the repo.We should only use the modern syntax of
rgb
andhsl
. (No need to update the tools directory, they would need much more work if we want to keep them…)