mdn / css-examples

Code examples that accompany the MDN CSS documentation
https://developer.mozilla.org/docs/Web/CSS
Creative Commons Zero v1.0 Universal
618 stars 854 forks source link

feat(css): add color-mix() tool #184

Closed OnkarRuikar closed 4 months ago

OnkarRuikar commented 5 months ago

The PR adds a tool to experiment with the CSS color-mix() function. Following is the screenshot of the tool: 1

bsmth commented 4 months ago

Thanks, @OnkarRuikar. Looking good! I made some suggestions on a branch, do you want to have a look here:

https://github.com/OnkarRuikar/css-examples/compare/css_color_mix...bsmth:css-examples:css_color_mix_brian?expand=1

bsmth commented 4 months ago

And just general question; why do we want to include Pickr? Not a blocker, just curious 🤔

OnkarRuikar commented 4 months ago

I've applied the changes.

And just a general question; why do we want to include Pickr?

Because HTML color input doesn't support alpha(transparency) channel: https://github.com/whatwg/html/issues/3400#issuecomment-606737019 .

bsmth commented 4 months ago

I've applied the changes.

Nice, taking a look again!

And just a general question; why do we want to include Pickr?

Because HTML color input doesn't support alpha(transparency) channel: whatwg/html#3400 (comment) .

Ah-ha, thanks for the hint 👍🏻

OnkarRuikar commented 4 months ago

LGTM, only last thing to think about is demonstrating that the percentage doesn't have to be a whole number;

:nerd_face: done.

bsmth commented 4 months ago

Merging now, thank you!