mdn / data

This repository contains general data for Web technologies
https://developer.mozilla.org
Creative Commons Zero v1.0 Universal
724 stars 189 forks source link

mask-position Initial value #713

Closed kimgaeun77 closed 6 months ago

kimgaeun77 commented 7 months ago

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

The page says that the mask-position Initial value is center, but when I tested it in Chrome, Firefox, etc., it was not center.

What did you expect to see?

I expected mask-position center as shown on the page.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details * Folder: `en-us/web/css/mask-position` * MDN URL: https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position * GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/css/mask-position/index.md * Last commit: https://github.com/mdn/content/commit/c77cfcd17e85db6c1b93160c70668f2ff6c2809c * Document last modified: 2023-07-20T07:38:29.000Z
bsmth commented 7 months ago

Thanks a lot @kimgaeun77 for raising this one. I dug a little into this and indeed, the initial value is 0% 0% (top-left corner). This is defined here: https://github.com/mdn/data/blob/af8a84ad4bdc9ea92fe74790eed43712c5668f6b/css/properties.json#L6868-L6883

I will move this into the data repo so we can fix it there.

github-actions[bot] commented 7 months ago

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

bsmth commented 6 months ago

This is now fixed in the linked PR. Thanks a lot for raising and fixing 👍🏻

kimgaeun77 commented 6 months ago

Yes, thank you too😊I have one question. It doesn't seem to have changed in the mdn official document(https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position) yet. Can you tell when it will change?

bsmth commented 6 months ago

I have one question.

Sure thing: your changes have been included in https://github.com/mdn/data/pull/715. This new version will be picked up automatically as a bumped dependency in Yari -> https://github.com/mdn/yari/blob/main/CHANGELOG.md and it should be visible when builds are done with this new version. It may take a few days, but there's no other manual tasks outstanding, as far as I know.

kimgaeun77 commented 6 months ago

Thank you so much for letting me know😊Have a nice day!!👍