mdn / data

This repository contains general data for Web technologies
https://developer.mozilla.org
Creative Commons Zero v1.0 Universal
727 stars 192 forks source link

update `zh-CN` to i10n patch 1 #734

Closed T34-active closed 6 months ago

T34-active commented 6 months ago

Description

Motivation

Additional details

Related issues and pull requests

github-actions[bot] commented 6 months ago

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

bsmth commented 6 months ago

Thanks for the PR! Is there a description available somewhere so we know the scope of the changes? (will there be a patch 2 or follow-up PRs?)

T34-active commented 6 months ago

Thanks for the PR! Is there a description available somewhere so we know the scope of the changes? (will there be a patch 2 or follow-up PRs?)谢谢你的公关!是否有可用的描述,以便我们知道更改的范围?(是否会有补丁2或后续公共关系?)

yes, Subsequent possible submission of patch 2

T34-active commented 6 months ago

OK /cc @yin1999 ,this is zh-CN reviewer

yin1999 commented 6 months ago

Hey @T34-active. Thanks for the translation. Actually, I've finished some translation in my fork (see: yin1999/data#1). I've reviewed some translation you added in this PR, and felt that some of the translations could be improved by yourself first. For example, unnecessary quantifier translations (e.g. 一个) and unnecessary characters in Chinese (e.g. 绝对长度 - 绝对 <length>, the character is not necessary).

Please do it by yourself first, and ping me again after you think it's ready for review by the l10n-zh team.

T34-active commented 6 months ago

/cc @yin1999 I fix a few content

T34-active commented 6 months ago

It's so hard that I wrote so many parts that basically wrong. just one question, How to find the Formal definition CSS property in JSON? @yin1999 @bsmth

yin1999 commented 6 months ago

It's so hard that I wrote so many parts that basically wrong. just one question, How to find the Formal definition CSS property in JSON? @yin1999 @bsmth

Search the references of those keys within this repo, or search the English text using Google, or bing, like this: https://www.google.com/search?q=%22an+absolute+length%3B+if+the+keyword+none+is+specified%2C+the+computed+value+is+0%22+site%3Adeveloper.mozilla.org&oq=%22an+absolute+length%3B+if+the+keyword+none+is+specified%2C+the+computed+value+is+0%22+site%3Adeveloper.mozilla.org

bsmth commented 6 months ago

Thanks a lot! Merging shortly 🚢

github-actions[bot] commented 6 months ago

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.