mdn / developer-portal

The code that generates the MDN Web Docs Developer Portal.
Mozilla Public License 2.0
61 stars 38 forks source link

Topics section #1720

Closed schalkneethling closed 3 years ago

schalkneethling commented 3 years ago

The topics list should be marked up as an unordered list. There is also an incorrect heading hierarchy.

A suggested restructuring could look something like:

<section id="topics" aria-labelledby="topics-main-heading">
  <h2 id="topics-main-heading">Browse products &amp; technologies</h2>

  <ul class=" mzp-l-card-quarter">
    <li class="mzp-c-card mzp-c-card-extra-small">
      <a class="mzp-c-card-block-link" href="/topics/browser-extensions/">
        <h3 class="mzp-c-card-title"><span>Add-Ons</span></h3>
        ...
      </a>
    </li>
    <li class="mzp-c-card mzp-c-card-extra-small">
      <a class="mzp-c-card-block-link" href="/topics/browser-extensions/">
        ...
      </a>
    </li>
    ...
  </ul>
</section>

Not the change in heading elements in the above code snippet.