search

mdn / developer-portal

The code that generates the MDN Web Docs Developer Portal.
Mozilla Public License 2.0
61 stars 38 forks source link

Topic detail page #1735

Closed schalkneethling closed 4 years ago

schalkneethling commented 4 years ago
  1. [x] The featured items should ideally be marked up as a list, something like:
<ul class="mzp-l-card-third">
  <li class="mzp-c-card mzp-c-card-small mzp-has-aspect-16-9">
    <a href="https://developer.mozilla.com/topics/firefox/security-and-privacy-tools-and-features/" class="mzp-c-card-block-link" data-type="external_page" target="_blank" rel="nofollow noopener">
    </a>
  </li>
  <li class="mzp-c-card mzp-c-card-small mzp-has-aspect-16-9">
    <a href="https://developer.mozilla.com/topics/firefox/security-and-privacy-tools-and-features/" class="mzp-c-card-block-link" data-type="external_page" target="_blank" rel="nofollow noopener">
    </a>
  </li>
  ...
</ul>

  1. [x] Headings, "What we're developing" - Main section title should he h2 and each individual card should then have an h3 level heading.

  2. [x] Cards should ideally be marked up as a list

<ul class="mzp-l-card-quarter">
  <li class="mzp-c-card mzp-c-card-extra-small mzp-has-aspect-16-9">
    <a href="https://hacks.mozilla.org/2020/06/new-in-firefox-78/" class="mzp-c-card-block-link " data-type="article" target="_blank" rel="nofollow noopener"></a>
  </li>
  <li class="mzp-c-card mzp-c-card-extra-small mzp-has-aspect-16-9">
    <a href="https://hacks.mozilla.org/2020/06/new-in-firefox-78/" class="mzp-c-card-block-link " data-type="article" target="_blank" rel="nofollow noopener"></a>
  </li>
  ...
</ul>
  1. [x] People section header needs to be a h4 and needs to be marked up as a list
stevejalim commented 4 years ago

First point will be handled by #1719 because it's the same component being reused there, but the rest need code changes

stevejalim commented 4 years ago

Second and third points are covered by #1736, so that leaves only the fourth point