search

mdn / express-locallibrary-tutorial

Local Library website written in NodeJS/Express; example for the MDN server-side development NodeJS module: https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs.
Creative Commons Zero v1.0 Universal
1.23k stars 695 forks source link

Populatedb - change to async/await semantics #166

Closed hamishwillee closed 1 year ago

hamishwillee commented 1 year ago

This replaces async module with JavaScript async-await. It's a little more efficient because it does creation of the genres, authors etc in parallel with each other, then in series. I also ran prettier. So pretty.

This is a very small part of addressing https://github.com/mdn/content/issues/24972

It can go in. The docs will be a little out of sync because they tell you to install async module, and this doesn't use it any more. But you still need to for rest of tutorial, so it does no harm.

hamishwillee commented 1 year ago

@bsmth Hmmm, now I need permission to merge here too. Annoying.

Can you please review, and make sure that @teoli2003 also has approval rights?

bsmth commented 1 year ago

I need permission to merge here too

The branch protection rules are lifted so approvals are no longer required for pull requests in this repo 👍🏻